fix(convert): handle file names with multiple dots #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luytena
force-pushed
the
fix-convert-filename
branch
4 times, most recently
from
ef0da69 to
3dabdd1
Compare
Ensure files with names containing dots in addition to the dot before the extension are handled correctly. The converted file name should correspond to the original file name replacing only the extension.
luytena
force-pushed
the
fix-convert-filename
branch
from
3dabdd1 to
3ae90f1
Compare
|
Due to issues with my current setup, I was unable to test the fix (besides through the test). @StephanH90 could you please take a moment to test the conversion to PDF for a file containing multiple dots? |
|
I checked it out on my computer and the conversion works fine with the new testfile: |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure files with names containing dots in addition to the dot before the extension are handled correctly. The converted file name should correspond to the original file name replacing only the extension.